Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test refactor and test all #184

Closed
wants to merge 5 commits into from
Closed

Test refactor and test all #184

wants to merge 5 commits into from

Conversation

yonahd
Copy link
Owner

@yonahd yonahd commented Dec 27, 2023

Split resource creation functions into separate functions from client creation.
Allowing reuse of code for all.go test

@codecov-commenter
Copy link

codecov-commenter commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fb6a2e3) 46.33% compared to head (8a830c4) 46.33%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #184   +/-   ##
=======================================
  Coverage   46.33%   46.33%           
=======================================
  Files          24       24           
  Lines        2236     2236           
=======================================
  Hits         1036     1036           
  Misses       1023     1023           
  Partials      177      177           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yonahd yonahd linked an issue Dec 27, 2023 that may be closed by this pull request
@doronkg
Copy link
Contributor

doronkg commented Mar 19, 2024

Hey, this PR should be updated with:

  1. all_test.go - TestGetUnusedAllNamespaced() & TestGetUnusedAllNonNamespaced()
  2. New unused resources tests (such as daemonsets, clusterroles, etc)

@yonahd yonahd closed this Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Test for GetUnusedAll functionality
3 participants